[TYPO3-core] Pushing to Gerrit correctly

[Ernesto Baschny [cron IT]]

Hi,

I guess "change in the guidelines" sounds more official than it actually
was done. We discussed it in our review chat, and basically everybody
agreed that they just "set the issue number as topic because we were
required to".

Christian argued that he had done several backports in the past reusing
the same Change-Id (which wasn't allowed in Gerrit's previous versions).

So, since:

a) we can group related changes by using the change-id:
https://review.typo3.org/#/q/I2ebfffd2ece8022136c4fcc8d0e12d552486dd32,n,z

b) we can still search for an issue (using tr:xxxxx, which searches for
the issue number in the commit message), see
https://review.typo3.org/#/q/tr:44732,n,z

the main points of using the issue number as a "topic" were gone.

This frees the topic to use it for what it originally was meant to: To
define a "scope" of the change, i.e. to group several related change
requests for a certain topic. Example topics could be "fal", "installer".

The release team has for example set "RELEASE" topic for every release
related commit, see:

https://review.typo3.org/#/q/project:TYPO3v4/Core+topic:RELEASE,n,z

The namespacing effort also used the topic before:

https://review.typo3.org/#/q/project:TYPO3v4/Core+topic:namespacing,n,z

So we dropped the requirement from the guide in Wiki (see [1] and [2])
and decided to "announce" that through the list. But I guess we forgot
to decide who was going to announce, and we simply didn't. :)

Maybe I'll just write the announcement on a separate thread to make sure
everybody reads it.

Cheers,
Ernesto


[1]
http://wiki.typo3.org/wiki/index.php?title=Contribution_Walkthrough_with_CommandLine&diff=64682&oldid=63720
[2]
http://wiki.typo3.org/wiki/index.php?title=Contribution_Walkthrough_with_TortoiseGit&diff=64678&oldid=64336


Markus Klein schrieb am 26.04.2013 11:12:
> Hi Dmitry!
> 
> There's been a change in the guidelines that Topic is not mandatory anymore.
> It was necessary in older Gerrit versions only. But since we can now reuse the changeID for backports,
> these can easily be found by simply clicking the changeID.
> Furthermore one can use the tr: search filter to search for forge ticket numbers.
> (This only works if the Releases: line in the commit message is in the last paragraph of the message.
> I encourage everybody to update her/his commit message hook from the Wiki again, which takes care of that!)
> 
> Kind regards
> Markus
> 
>> -----Original Message-----
>> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
>> bounces at lists.typo3.org] On Behalf Of Dmitry Dulepov
>> Sent: Friday, April 26, 2013 11:05 AM
>> To: typo3-team-core at lists.typo3.org
>> Subject: [TYPO3-core] Pushing to Gerrit correctly
>>
>> Hi!
>>
>> There are a lot of commits to Gerrit that do not follow our official
>> guidelines:
>> https://review.typo3.org/#/q/status:open+project:TYPO3v4/Core+branch:m
>> aster,n,z
>>
>> You can see that many commits miss the topic. Is there any technical way to
>> enforce the correct submission to Gerrit (for example, reject a submission
>> without a topic)?
>>
>> --
>> Dmitry Dulepov
>> TYPO3 CMS core & security teams member
>> _______________________________________________
>> Before posting to this list, please have a look to the posting rules on the
>> following websites:
>>
>> http://typo3.org/teams/core/core-mailinglist-rules/
>> http://typo3.org/development/bug-fixing/diff-and-patch/
>> _______________________________________________
>> TYPO3-team-core mailing list
>> TYPO3-team-core at lists.typo3.org
>> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core
>