[TYPO3-core] Deprecation issue in 6.0 (helpText)

[Markus Klein]

Hi!

Thanks for bringing this up.

The problem here is/was:
The user option edit_showFieldHelp has been deprecated. Since helpText() relies on this option
($GLOBALS['TCA_DESCR'] must be loaded prior to this function and $GLOBALS['BE_USER'] must have "edit_showFieldHelp" set to "text", otherwise nothing is returned)
it was deprecated too.

The strange thing is that the call in wrapInHelp() cannot be replaced, because it is invoked every time its  4th parameter is omitted. (Which is the case in most calls in Core)
The question is: Is the behavior of wrapInHelp() wrong, or is the description of helpText() wrong that it relies on edit_showFieldHelp?

Kind regards
Markus


> -----Original Message-----
> From: typo3-team-core-bounces at lists.typo3.org [mailto:typo3-team-core-
> bounces at lists.typo3.org] On Behalf Of Xavier Perseguers
> Sent: Friday, April 26, 2013 11:01 AM
> To: typo3-team-core at lists.typo3.org
> Subject: Re: [TYPO3-core] Deprecation issue in 6.0 (helpText)
> 
> Hi Francois,
> 
> > There seems to be a deprecation issue starting with TYPO3 CMS 6.0.
> > Method \TYPO3\CMS\Backend\Utility\BackendUtility::helpText() was
> > marked as deprecated (without replacement hint BTW), but it is still
> > called by \TYPO3\CMS\Backend\Utility\BackendUtility::wrapInHelp().
> > This leads to the deprecation log being absolutely flooded with
> > warnings. Furthermore this deprecation sounds wrong, since the method
> > is still actively used by the Core.
> >
> > This change is related to the following cleanup:
> >
> > https://review.typo3.org/#/c/14950/
> >
> > which was apparently a bit excessive. I would suggest to simply revert
> > the deprecation statement in
> > \TYPO3\CMS\Backend\Utility\BackendUtility::helpText(). Does that sound
> > ok or was there a further plan for this?
> 
> Thanks for writing this post. I waited as well hoping for a fix but it did not
> come. Deprecating something without a proper replacement is a no go so if it
> has not been fixed, we should in fact revert this message flooding.
> 
> Cheers
> 
> --
> Xavier Perseguers
> Release Manager TYPO3 4.6
> 
> TYPO3 .... inspiring people to share!
> Get involved: http://typo3.org
> 
> _______________________________________________
> Before posting to this list, please have a look to the posting rules on the
> following websites:
> 
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.typo3.org
> http://lists.typo3.org/cgi-bin/mailman/listinfo/typo3-team-core