[TYPO3-core] Change CGL for inline comments?

Stefan Neufeind typo3.neufeind at speedpartner.de
Sat Sep 22 19:18:05 CEST 2012


On 09/22/2012 06:31 PM, Helmut Hummel wrote:
> Hi,
> 
> our CGL currently state that inline comments must be indented one tab
> more than the following code line.
> 
> This is a speciality that only exists (as far as I know) in the TYPO3
> project for historical reasons.
> 
> One downside is, that IDEs lack support for auto formatting the comments
> that way.
> 
> With the switch to namespaces, the script accidently reverted this
> coding style and set *all* inline comments on the same indenation level
> as the following code.
> 
> During the CI code sprint we discussed if it would make sense to change
> the CGL here and leave it, as we have it now instead of fixing all the
> comments.
> 
> We all agreed that we should go that way and change the CGLs
> 
> Any major downsides to do so?

I personally also favour to *not* indent it one more tab - and leave it
as it is now after the namespace-change. It's just that I previously
didn't propose it since it "has always been like that" :-)

If the core-team agrees on that, please also mention if that applies to
6.0 only or if it can also take effect for code newly added to the codebase.


Kind regards,
 Stefan


More information about the TYPO3-team-core mailing list