[TYPO3-core] Popular stdWrap issue

[Helmut Hummel]

Hi Markus,

On 17.07.12 12:01, Markus Klein wrote:
> Hi Core Devs,
>
> could someone please take a closer look at [1].
> People are already post +1s to forge, so it seems that is quite an important issue.
> The patch [2] already has enough votes from anybody.

I mentioned already in the patch set 3 that unit tests should be added 
for this change.

It is not hard to do so. The most complicated thing is to know what the 
expected baviour is, which is required for a successful review anyway.

I fear that the magic introdced[1] is unfixable without a real SQL query 
parser. The easiest way to "fix" it would be to revert the whole thing 
and document that you need to add the versioning fields in TypoScript if 
you need the workspace preview.

just my 2 cents

[1]http://forge.typo3.org/issues/17284

Kind regards,
Helmut

-- 
Helmut Hummel
Release Manager TYPO3 6.0
TYPO3 Core Developer, TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org