[TYPO3-core] Commit message nitpicking...

Jigal van Hemert jigal at xs4all.nl
Sun Feb 19 10:41:33 CET 2012


On 19-2-2012 9:17, Tolleiv Nietsch wrote:
> 1) Nitpickers - Y U NO follow "patch for a patch" rules? [2] It's soooo
> easy - fetch the patch, amend the commit message and push.

This is also true for things like variable names, function/method names, 
CGL, whitespace, etc. Don't give a -1, but push an improved version 
instead and give a +1.

3) Only a code review.
There are very few situations where one would only give a positive vote 
by testing and not by reading (for example a change which has mysterious 
code for you (let's say you don't know nothing about ExtJS) but you the 
obvious bug is solved)).
If you take the time to read the code and nit pick over the spaces, 
tabs, etc., please also take the time to actually test it!

4) More reviews than necessary
If three or four people already did a code review and approved it then 
there is no obvious need to give another positive review. There are 
plenty of patches without reviews who could use some TLC...

Kind regards / met vriendelijke groet,

Jigal van Hemert.

More information about the TYPO3-team-core mailing list