[TYPO3-core] Bug in Gerrit

[Markus Klein]

Hello!

 

Please, can a gerrit pro take a look at this issue: https://review.typo3.org/#change,1317

There seems to be a serious problem with diff viewing when applying changes to the bottom of a file. (having no newline at the end)

The patch is ok, but the diff view doubles the last line of base.

 

In this case the following is shown:

}

+}

+?>

 

Whereas the patch says:

-}

\ No newline at end of file

+}

+?>

\ No newline at end of file

 

 

Kind regards

Markus

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110330/87619108/attachment.htm>