[TYPO3-core] RFC #16223 : Bugfix : Failed backend userlogins are not written to syslog using saltedpasswords

Bjoern Pedersen bjoern.pedersen at frm2.tum.de
Fri Mar 18 10:33:03 CET 2011

Am 18.03.2011 09:46, schrieb Jigal van Hemert:
> Hi,
> On 18-3-2011 9:12, Bjoern Pedersen wrote:
>> Almost correct. The base class log function is calles "writelog" (all
>> lower case), the additional log function in saltedpasswords "writeLog"
>> (camel case, first word lower case). So it should be enough to add calls
>> to $this->writelog... (lower case).
> Unfortunately function names are case-insensitive in PHP (See "Note"
> between Example #3 and #4 [1]).
> Both functions are the same (although the function name in the extended
> class should be exactly the same as in the base class to keep things
> clear for developers).
> [1] http://php.net/manual/en/functions.user-defined.php
Ok. Then the patch looks fine. Although I would prefer, if the log
function in salted passwords is rewritten to just add to the parent
class, instead of overwriting it with a totally different semantik.


More information about the TYPO3-team-core mailing list