[TYPO3-core] RFC #17388: Bug: TCA type "select", renderMode "tree", maxitems 1 doesn't work

[Marco Huber]

This is a GIT patch request.

Type: Bugfix

Bugtracker references:
http://bugs.typo3.org/view.php?id=17976

Branches: 4.5, Trunk

Problem:
I want to use the new TCA tree, but when I configure 1 as maxitems I 
can't select a tree node.

This happens, because this.countSelectedNodes in 
t3lib\js\extjs\tree\tree.js is 1 even when I create a new record. And 
this.countSelectedNodes is 1 because $valueArray in 
t3lib\tceforms\class.t3lib_tceforms_tree.php in the function renderField 
always has at least one entry.

$valueArray is created by exploding $PA['itemFormElValue']. In fresh 
records $PA['itemFormElValue'] is 0 and not NULL (or not set) and has no 
other effects. But $valueArray has an entry and that's why 
count($valueArray) is 1 and then this.countSelectedNodes is also 1.

To reproduce this issue you can use this TCA (Thanks to Steffen: 
http://lists.typo3.org/pipermail/typo3-team-core/2010-November/044931.html):
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']['renderMode']
= 'tree';
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']['maxitems'] = 1;
$GLOBALS['TCA']['pages']['columns']['fe_group']['config']['treeConfig']
= array(
      'parentField' => 'subgroup',
      'appearance' => array(
          'expandAll' => TRUE,
          'showHeader' => TRUE,
      )
);



Solution:
To fix this issue $PA['itemFormElValue'] should be only exploded if it's 
not 0. Like I wrote before, this is done in 
t3lib\tceforms\class.t3lib_tceforms_tree.php and fixed in the appended 
patch.

Fixing this issue causes a little follow up in 
t3lib\js\extjs\tree\tree.js. This is also fixed in the patch.

I hope the patch file's syntax is correct, this is my first git patch ;-)

Kind regards,
Marco
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: fix_tcatree_maxitem1.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110316/539eb4e8/attachment.txt>