[TYPO3-core] RFC #17374: implode() issues in Install Tool

Steffen Gebert steffen at steffen-gebert.de
Fri Jan 28 22:57:05 CET 2011


Hi!

This is a SVN patch request.

Type: Bugfix

Bugtracker reference:
http://bugs.typo3.org/view.php?id=17374

Branches:
trunk, 4-5

Problem:
The Install Tool has some problems with the implode() function.
In a few places, it might try to implode undefined variables, at least 
in one case, this is really critical: In the Upgrade Wizards, when no 
database queries are performed (thus $databaseQueries is undefined), but 
later it should be imploded. That's what the bug report is about and 
also occurred for me.

Solution:
Always initialize variables, which are imploded afterwards.

Note:
I also 2-3 times reordered the parameters to the correct order (first 
glue, then array) and removed some unused variables.

Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 17374.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110128/97c2d82e/attachment.txt>


More information about the TYPO3-team-core mailing list