[TYPO3-core] RFC #17114: Bug: Install Tool does not install extensions properly

[Ernesto Baschny [cron IT]]

Hi Francois,

yes, I like it! I removed the lines

+		$extensionManagerConnection->extensionList =
t3lib_div::makeInstance('tx_em_Extensions_List');
+		$extensionManagerConnection->extensionDetails =
t3lib_div::makeInstance('tx_em_Extensions_Details');

because those are not needed anymore (see Steffen's v3).

+1 by reading and testing (v5 attached).

The mentioned fixes in EM (template instance and forceDB fix) are
already in core's trunk (and also in EM's trunk repository of course),
Steffen kindly committed them for us to test more easily.

Cheers,
Ernesto


François Suter schrieb am 19.01.2011 22:02:

>> Tested it together with the wizard from #16926 and it worked.
>>
>> So +1 on reading and testing.
> 
> Thanks.
> 
> Now as I was looking to commit this, it occurred to me that there's
> another wizard installing extensions - namely "installNewSysexts" -
> which suffers from the same problem. So I propose to move the code to
> add extensions to Tx_Install_Updates_Base so that any wizard that wants
> to add an extension actually inherits from a clean method for doing so.
> 
> Attached v4 does this. Do you agree with that? It would be worth a new
> round of testing. It worked flawlessly for me with all three wizards
> that install extensions (outsourced sysexts, new sysexts and workspace
> migration).
> 
> I made the choice to encapsulate the creation of the connection to the
> EM in a specific method and not store that connection in a member
> variable, because it's not needed by many wizards so it wasn't worth
> using extra memory for this.
> 
> Cheers
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 17114_v5.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110119/66448797/attachment-0001.asc>