[TYPO3-core] RFC #15739: Sprite API: Missing icon "Undelete and edit" in DB Check

Patrick Broens patrick at patrickbroens.nl
Fri Jan 14 12:27:45 CET 2011


Hi,

This is a SVN patch request.

Type: Bugfix

BT reference: http://bugs.typo3.org/view.php?id=15739

Branches: trunk

Problem:
In the module "DB Check", option Fullsearch you can search the different
database records.
When you choose Extended Search and check "Also show deleted entries"
these entries are shown. Only the icon "Undelete and edit" is missing.
See BT for screenshot

Solution:
The problem was not the missing icon, but the wrong icon name in a call
to t3lib_iconWorks::getSpriteIcon. Name has been changed.

Notes:
The icon for 'undelete only' has the name 'actions-edit-restore'.
The icon for 'undelete and edit' now has the name
'actions-edit-undelete-edit' because it was already registered with that
name. It would be nicer to have the name 'actions-edit-restore-edit' so
both use 'restore', but it might be possible extensions are using this
icon as well, and they will break if we change the name of the icon
itself. What do you think?

Cheers

Patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20110114_RFC_15739.diff
Type: text/x-diff
Size: 1231 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110114/c58b1662/attachment.diff>


More information about the TYPO3-team-core mailing list