[TYPO3-core] FYI: #13319: Implement plupload

Wed Jan 12 10:49:33 CET 2011

Hi Steffen and Christian,

> this patch will committed tomorrow to be part of beta4 release.
>
> plupload was integrated by FAL team in their file list module.
> Thanks to Christian Müller who ported the script to core file list,
> simplified the user interface, localized and tuned it.
Wow, I'm impressed of taking over and that you found a cleaner way, to 
put the files into TCEfile.

Christian, I really appreciate you backporting ExtJS-knowledge from v5 
to help us with all our ExtJS problems :) We really need you!

I wonder that you found a way, to solely use multipart-uploads. Besides 
that the author of plupload engages to not use multipart (but not 
strongly), I preferred binary streams in my first proof-of-concept, as 
then Flash doesn't do the upload itself, but the browser handles them 
(will come to the Flash problems later).
My initially intention to play with plupload was to circumvent those 
Flash-poorness.

Nevertheless, sorry for playing the bad guy again, but I have some 
concerns and just write everything, which comes to my mind. I ordered 
them somehow after priority/importance (descending). Please also see the 
screenshots, I did not write everything down.

* Why is this an FYI?

* HTML4 engine does not work for me, fails with Error 500, probably 
because this URL might not work:
http://example.com/typo3/ajax.php?name=myfilename.JPG
The multipart_params values have to be set to target ajax.php to the 
right class.
See the one screen shot. FF says Queued, Opera says Finished, however it 
is *not* uploaded.

* You remove the LLL fileUpload_infoComponentOverrideFiles

* The often-occured problems with Flash are: Not working with .htaccess 
protection, not working with self-signed SSL in non-IE browsers. I added 
many explanations to swfupload to give the user/admin a hint, what wents 
wrong.
Plupload just shows a red I/O error (which is basically the message 
coming from flash, not more) and closes after few milliseconds. As Flash 
has priority after HTML5, many users will use this and encounter this 
problem again.

* I would suggest to add a small status indicator, what engine is used 
by the user. This would help us in case of bug reports, to easier 
reproduce the problem. I'm especially talking here of the frequent 
problems with Flash.

* I also dreamed of having a per-user switch to change the upload engine 
(which is saved in the BE user settings). This would help to override 
the default order of trying to use flash.

* There's no way to overwrite existing files. It automatically gets 
renamed to _01

* Not an issue of plupload probably, but there's even an upload icon in 
directories, for which the web server does not have write access.

* However plupload uploads files there and the file module later shows 
the FlashMessage
 > 1: Uploaded file could not be moved! Write-permission problem in
 > "/opt/local/apache2/vhosts/typo3dev/fileadmin/new/"?

* Dependent on the user setting, it would be good, if only swfupload or 
plupload JS would be loaded.

* Text "NaN MB" should be hidden, if size could not be read

* Please respect the separation of CSS into structure and visual. The 
following definitions have to go to visual:
border, font, cursor, white-space, opacity/filter, background, line-height.
* Please use tabs in CSS

* What's the intention of the CSS definitions .silk-(add|edit|..) for 
the icons? The class names are meaningless, so I think they're a 
leftover from the ExtJS-plupload example?
Icons have to be copied and named according to the naming scheme (e.g. 
actions-upload-add, actions-upload-cancel).
Should there be any icons currently? IMHO it's a bit unintuitive, eyes 
would get the meaning of the buttons faster with icons.

* I try to avoid using font-definitions in ExtJS skin and am 
continuously removing old 10px definitions in xtheme-t3skin.css.
However there's one, which I didn't encounter and thus still exists:
.x-window-mc { font: 10px verdana,arial,tahoma,helvetica,sans-serif; }
We should check, whether this destroys sth. and remove it, if not. You 
overwrite it (which is IMHO fine in principle) with 
arial,tahoma,verdana,helvetica, whilst the BE uses this by default: 
Verdana,Arial,Helvetica,sans-serif

Please don't get me wrong. I would have really appreciated this change, 
if it would be added earlier. I'm pretty sure, the most important 
problems are easily to fix for you.

Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member

Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 10.20.45.png
Type: image/png
Size: 25147 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0006.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 10.08.55.png
Type: image/png
Size: 49131 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0007.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 09.50.44.png
Type: image/png
Size: 27298 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0008.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 09.49.36.png
Type: image/png
Size: 18353 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0009.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 09.48.20.png
Type: image/png
Size: 19617 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0010.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen shot 2011-01-12 at 09.25.24.png
Type: image/png
Size: 20807 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110112/97a8e55a/attachment-0011.png>