[TYPO3-core] RFC 16630: migrateWorkspaces in Install-Tool does not work, if extbase is not intalled

[François Suter]

Hi Tolleiv,

I took a quick look at this patch and tried to test it by going through 
the migration steps on some default install. Because the error handler 
was not set up to show exceptions, the wizard actually failed silently. 
Or at least failed partly, because my end result was that extension 
"workspaces" was not installed, but the wizard did not show up anymore.

This experience reinforces what has been discussed in RFC #16935, that 
the two wizards related to versioning/workspaces should be merged and 
the whole stuff handled in one step.

In particular testing for the existence of the sys_workspaces() table 
and whether it contains any workspaces is not enough, because 1) it may 
not exist or 2) it may exist but not contain any workspaces (if the 
Draft has been disable, which was already possible with 4.4). Thus the 
wizard should test if "workspaces" (and "version") is installed at all.

> +if (TYPO3_MODE == 'BE'&&  PATH_typo3_mod != 'install/') {

A cleaner test is possible:

if (TYPO3_MODE == 'BE' && !(TYPO3_REQUESTTYPE & 
TYPO3_REQUESTTYPE_INSTALL)) {
...

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch