[TYPO3-core] RFC #16911: Restructure of t3lib_utility_Mail hook subscriber

Jigal van Hemert jigal at xs4all.nl
Tue Jan 4 14:55:42 CET 2011


Hi,

This is a SVN patch request.

Type: Bugfix / Clean up

BT reference: http://bugs.typo3.org/view.php?id=16911

Branches: trunk

Problem:
t3lib_utility_Mail used callUserFunc for a hook. This hook was used to 
reroute all mails from that class to the new Swift Mailer. The result 
was an ugly class name and pretty messy code.

Solution:
Ingo Renner supplied a nice interface and modified the hook to allow 
clean use of that interface.
Changes of issue 16879 are included in this rewrite.
A small fix for quoted display names is included.
Some lengthy pieces of code and repeating code were moved to separate 
methods.

How to test:
Make form content element and test with and without "HTML mode enabled"

Notes:
Maybe t3lib/mail/class.tx_t3lib_mail_hooks.php needs to be renamed to 
t3lib/mail/class.t3lib_mail_swiftmaileradapter.php before applying the 
patch.
Furthermore this file had Windows line endings; these have been changed 
to Unix line endings. Maybe this needs to be done before applying the 
patch if errors about failing chunks appear.

-- 
Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16911.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110104/188edf33/attachment.asc>


More information about the TYPO3-team-core mailing list