[TYPO3-core] RFC #14935: Install tool password can be overwritten by an extensions' ext_localconf.php

Oliver Klee typo3-german-01 at oliverklee.de
Tue Jan 4 11:10:26 CET 2011


Hi,

+1 by reading with the following three nits fixed:

1. please use strict comparison (===)

2. please use empty instead of == '' (because empty also is true if the
variable is not set)

3. please add a pair of parenthesis around the second expression for
better readability:

if ($p && md5($p) == TYPO3_InstallToolPassword)


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member


More information about the TYPO3-team-core mailing list