[TYPO3-core] RFC #16891: Bug: shopic.php causes a fatal error if parameters GET variable is not an array

[Franz Holzinger]

Forget my last posting!

I have seen it now:

+		if (!$this->file || !isset($parametersArray) || 
!is_array($parametersArray))	{
+			die('Parameter Error: No file or no parameters given.');
  		}

However:

Is is necessary to die here? IMHO a die is not a good solution.

- Franz


Le 03/01/2011 10:59, Franz Holzinger a écrit :
> Hello Helmut,
>
> this line could be a problem:
>
> $this->parametersEncoded = implode($parametersArray);
>
> Please add :
>
> if (isset($parametersArray) && is_array($parametersArray)) {
> $this->parametersEncoded = implode($parametersArray);
> }
>