[TYPO3-core] RFC #1525: Bug: Possibility to add multiple "includeLib" plugins

[Jigal van Hemert]

Hi,

Thanks for your patch!

On 26-2-2011 2:52, Robert Heel wrote:
> Solution:
> Do a loop and add all plugins using "includeLib" with page.1000, page
> 1001, ...

page.1000 is kind of 'reserved' for adding plugins this way. If multiple 
plugins want to use this, wouldn't a COA be a way? This way it won't 
give problems when page.1001,1002, etc. are already in use.

About the code itself:
- the use of 'global' is discouraged, so use $GLOBALS['TYPO3_CONF_VARS'] 
instead.
- eregi is deprecated in PHP 5.3. In this case 
t3lib_div::isFirstPartOfStr() would be more appropriate (in case of real 
regular expressions the preg_* family should be used)
- why check for page.<pageObjKey> in 
defaultTypoScript_setup.cssstyledcontent/static/ while it is added to 
defaultTypoScript_setup.43 ?
- some CGL stuff: descriptive and non-cryptic variable names 
($pageObjKey), spaces around operators (also the dot operator)

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh