[TYPO3-core] FYI72: #17670: Remove deprecaded functions scheduled for removal in 4.6

[Xavier Perseguers]

Hi,

Christian Kuhn wrote:
> On 02/19/2011 03:29 PM, Christian Kuhn wrote:
>> Mission:
>> Remove all deprecated methods which are not used by core and logged by
>> logDeprecatedFunction() and scheduled for removal in 4.6.
>
> trunk rev. 10547.
>
> pi_wrapInBaseClass() accidentally made it to v1 ... fixed in attached
> final version.

Problem with this change. Please revert part of your patch for 
typo3/template.php as you removed a method that was deprecated in 4.5 
and thus should stay until 4.7:

  	/**
-	 * Returns dynamic tab menu header JS code.
-	 * This is now incorporated automatically when the function 
template::getDynTabMenu is called
-	 * (as long as it is called before $this->startPage())
-	 * The return value is not needed anymore
-	 *
-	 * @deprecated since TYPO3 4.5, as the getDynTabMenu() function 
includes the function automatically since TYPO3 4.3
-	 * @return	string		JavaScript section for the HTML header. (return 
value is deprecated since TYPO3 4.3, will be removed in TYPO3 4.5)
-	 */
-	function getDynTabMenuJScode()	{
-		t3lib_div::logDeprecatedFunction();
-		$this->loadJavascriptLib('js/tabmenu.js');
-		// return value deprecated since TYPO3 4.3
-		return '';
-	}
-
-	/**

This breaks TemplaVoilà in Web > Page:

Fatal error: Call to undefined method template::getDynTabMenuJScode() in 
/Users/xavier/Sites/typo3dev.loc/mysql/typo3conf/ext/templavoila/mod1/index.php 
on line 509

Cheers
Xavier