[TYPO3-core] RFC #17564: Bug: Red question marks in QuickEdit instead of icons.

[Helmut Hummel]

Hi,

On 13.02.11 15:16, Bürokommunikation Ettmüller wrote:

> TCEForms->getIconHTML() is_file fails (line 4159), when checking for a
> static image file from db_layout.php (Quickview)

good catch!

The problem is, that $this->getIcon returns the path to the icon
relative to the current script, whereas the is_file() check prepends
PATH_typo3 to this path only.

> A solution for me now could be the following, but I am not sure if it has no
> sideeffects.
> 
> - if (is_file(t3lib_div::resolveBackPath(PATH_typo3 . $iconArray[0]))) {
> + if (is_file(t3lib_div::resolveBackPath(PATH_typo3
> .$GLOBALS['temp_modPath']. $iconArray[0]))) {

Solutions would be to remove the backPath again from the path returned
from getIchon() or just add the module path to PATH_typo3 like you did.

So your solution is just fine and resolves the bug, however I would
prefer to use the PATH_typo3_mod constant instead the temporary global
variable for that (see attached patch).

> Notes:
> This is my first request patch. I hope that everything is correct :)

Perfect. Thanks for your contribution!

Kind regards,
Helmut

-- 
Helmut Hummel
TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 17564_v2.diff
Type: text/x-patch
Size: 725 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110213/2a1be434/attachment.bin>