[TYPO3-core] RFC: #17490: After introducing the locking in #17289 no CSRF token will ever be deleted.

[Jigal van Hemert]

Hi,

On 5-2-2011 17:51, Helmut Hummel wrote:
> Not exactly, because $this->droppedTokenIds contains the token ids as
> value not as keys. But this can be changed easily of course.

You're absolutely right (it was a bit early in the morning, I guess).

> Additionally these array functions are often very expensive performance
> wise. For this case it means that the foreach variant is faster up to 3
> dropped tokens.

I would expect the internal functions to be relatively fast, but in the 
case of PHP one can never be sure...

I'm fine with the original patch.

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh