[TYPO3-core] RFC: #17490: After introducing the locking in #17289 no CSRF token will ever be deleted.

[Jigal van Hemert]

Hi,

On 5-2-2011 0:30, Helmut Hummel wrote:

Nitpicking, can't we simplify:

200» » $this->tokens·=·array_merge($tokens,·$this->addedTokens);
201» » foreach·($this->droppedTokenIds·as·$tokenId)·{
202» » » unset($this->tokens[$tokenId]);
203» » }

to:

$this->tokens = array_diff_key(
	array_merge($tokens, $this->addedTokens),
	$this->droppedTokenIds
);

Other than that: +1 by reading and testing

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh