[TYPO3-core] RFC #17342: t3lib_formprotection_BackendFormProtectionTest causes php fatal error

[Helmut Hummel]

Hi,

On 26.01.11 18:50, Helmut Hummel wrote:

> Nikolas Hagelstein wrote:
>>
>> Notes:
>> This is just a quickfix. It would be better to stop messing arround with
>> GLOBALS within tests and the actuall class implementation.
>>
>> Something like: isAuthorizedBackendSession($beSession) and injection of
>> the current beSession on construction would be much cleaner and easier
>> to test imho. But that is another story.

OK. After rethinking this, I agree, that changing this, will be a
refactoring, that should go into another RFC.

So please ignore my v2 and consider this v3 instead.

Easy to test: Run unittests before and after applying the patch. With
this patch, the tests a green again.

Kind regards,
Helmut

-- 
Helmut Hummel
TYPO3 Security Team Leader

TYPO3 .... inspiring people to share!
Get involved: typo3.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 17342_v3.diff
Type: text/x-patch
Size: 1779 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20110204/b71e95fd/attachment.bin>