[TYPO3-core] RFC #15800: Cleanup CSH Code

Benjamin Mack benni at typo3.org
Wed Sep 29 15:00:12 CEST 2010


Hey Helmut,

On 24.09.10 21:32, Helmut Hummel wrote:
> Is there a reason why you use a pipe ("|") as separator of table and
> field and use split() in the JS code to then concatenate the two strings
> with '.' Why not use a dot straight ahead (see attached patch).
Good point. Thanks!

> If the href attribute is not needed, why adding it with an emty value.
> AFAIK it is not mandatory to have a href attribute in a link tag.
yup. again: Thanks!

> Last thing: are there CGLs for JavaScript? Is there a reason you use
> abbreviated variable names like "el" or "anchorEl" or "evt"?
nope. looks like I read too much Ext and jQuery code :D

All the best,
Benni.


More information about the TYPO3-team-core mailing list