[TYPO3-core] RFC #15801: Deprecate t3lib_div::rm_endcomma
Helmut Hummel
helmut at typo3.org
Sat Sep 25 15:39:37 CEST 2010
Hi Thorsten,
On 25.09.10 15:13, Thorsten Kahler wrote:
>
> would you mind fixing some white space stuff and using the default order
> for implode() parameters? See attached version 2 of the patch.
Yeah, but this is wrong:
implode(array_keys(',', $admin->page_idArray));
should be:
implode(',', array_keys($admin->page_idArray));
And if we are cleaning up, we should add even more whitespaces :)
$id_list = '-1,0,' . implode(array_keys(',', $admin->page_idArray));
I would suggest do this cleanup in a seperate commit.
apart from that +1 by reading
Helmut
More information about the TYPO3-team-core
mailing list