[TYPO3-core] RFC #15644: Replace magic numbers for shortcut_mode with class constants

Steffen Gebert steffen at steffen-gebert.de
Fri Sep 24 18:16:57 CEST 2010


On 05.09.10 21:08, Steffen Gebert wrote:
> Type: Bugfix/Clean-up
>
> Bugtracker reference:
> http://bugs.typo3.org/view.php?id=15644
>
> Branches:
> trunk
>
> Problem:
> Option shortcut_mode uses magic numbers to distinguish the option's value.
>
> Solution:
> Replace them with meaningful class constants:
>  > const SHORTCUT_MODE_NONE = 0;
>  > const SHORTCUT_MODE_FIRST_SUBPAGE = 1;
>  > const SHORTCUT_MODE_RANDOM_SUBPAGE = 2;
>  > const SHORTCUT_MODE_PARENT = 3;

attached patch moves the constants to t3lib_pageSelect

Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 15644_v2.diff
Type: text/x-diff
Size: 2545 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100924/2d740ee3/attachment.diff>


More information about the TYPO3-team-core mailing list