[TYPO3-core] RFC: #3908: DisplayCond => VERSION:IS:false always returns true

[Dmitry Dulepov]

Hi!

Benjamin Mack wrote:
> attached is a new version for trunk that has all the CGL bells and whistles.

Still not all:

+	switch((string)$parts[1]) {

must be

+	switch ((string)$parts[1]) {

These two lines contains coding overhead:

+	$isNewRecord = (intval($row['uid']) > 0 ? FALSE : TRUE);
+	$isUserInWorkspace = ($GLOBALS['BE_USER']->workspace > 0 ? TRUE :

It could be shorter:

+	$isNewRecord = (intval($row['uid']) <= 0);
+	$isUserInWorkspace = ($GLOBALS['BE_USER']->workspace > 0);

-- 
Dmitry Dulepov
TYPO3 core&security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/