[TYPO3-core] RFC: #15290: Bug: Wrong behaviour of workspace preview setting "Enable Frontend Preview"

[François Suter]

Hi,

> i created a new patch that is more simple and solves the problem.
>
> The real problem was wrong setting:
> TYPO3.configuration.inWorkspace has to be
> top.TYPO3.configuration.inWorkspace

Sorry, but your patch does not solve all problems. It solves the following:

- when in the LIVE workspace, there's no preview, split or otherwise. 
This is fine.

However when in a workspace, there are still problems:

- with "Enable frontend preview" checked, you get the split preview, 
which is wrong. It should be the "full screen" preview
- with "Enable frontend preview" *not* checked, you get the "full 
screen" *LIVE* version

Attached is v6 (just for trunk, will do for 4.4 if patch for trunk is 
ok), which combines your correction to the JS file and the previous 
version's correction to the PHP file. With this patch I get a correct 
behavior across the board.

Let me summarize the expected behavior:

- in LIVE workspace: always the live page, no matter whether "Enable 
frontend preview" is checked or not
- in some other workspace:
1) with "Enable frontend preview" checked: "full screen" preview of that 
workspace's version
2) with "Enable frontend preview" *not* checked: split preview comparing 
the LIVE version, the workspace's version, plus the workspace "command" 
screen.

Cheers

-- 

Francois Suter
Cobweb Development Sarl - http://www.cobweb.ch
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 15290_v6_trunk.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100918/352fb6e5/attachment.asc>