[TYPO3-core] RFC #12887: Bug: User Tools/Worspace screen stage change buttons problem

[Gosign | Caspar Stuebs]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

I have tested the patch and it works, but I have 2 suggestions:

Am 08.08.2010 12:17, schrieb Steffen Kamper:

> by reading i see that the patch is incomplete or/and an old glitch is
> still in.
> 
> In function displayWorkspaceOverview_stageCmd there is the var $sId
> which is set depending on $rec_off['t3ver_stage']. You did the checks
> now with the second which seems to be ok.
> For every stage the first var is set, but not for the case
> $rec_off['t3ver_stage'] == 10 - then the var is NULL and leads to
> problems, especially in the line
> $this->stageIndex[$sId][$table][] = $rec_off['uid'];
> 
> This should be fixed too ;)

First, I don't think that this is a problem due to the fact the the
given line is not called if $rec_off['t3ver_stage'] == 10.

In my opinion the check if ($rec_off['t3ver_stage'] != 10) (or < 10 !?)
should by moved to the parent if statement, because the $onClick
variable is not used at all if $rec_off['t3ver_stage'] == 10.

The second thing is, that the reject action should not be parsed, if the
state is 'editing' ($rec_off['t3ver_stage'] == 0), because I don't see
the need that an editor should reject his own work before sending it to
review. So for the reject if statement it should be
($rec_off['t3ver_stage'] > 0)

I have added 3 patches _v3 for 4.3, 4.4 and Trunk, including these changes.

Viele Grüsse

Caspar Stuebs
Entwicklung

***Gosign im Jahrbuch der Werbung 2009***

NEW | We web pink: www.bebegeneration.de
We web green: www.greenpeace-hamburg.de
We web baguette: www.renault-safety.com

- -- 

Gosign media. GmbH | We web ideas.
Lokstedter Weg 36 | 20251 Hamburg
Tel. +49 (0) 40 / 31 70 15 00 | Fax  +49 (0) 40 / 31 70 15 02
eMail caspar at gosign.de | Internet www.Gosign.de | Skype caspar.stuebs

Amtsgericht Hamburg HRB 112197 | Ust-IdNr. DE215891388
Geschäftsführung Bert Gogolin

Greenpeace energy: Gosign läuft mit ehrlichem Strom.
Diese Mail bitte nur ausdrucken, wenn es wirklich sein muss.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkyQ7MEACgkQBN8gVNLcSL5RvACfRNWJWbL9FiXrwcemuKPtLy8f
0/IAn0RpDEwfWtUYh3Eb8ya9JJHeWIvi
=DkTN
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12887_v3_T3_4_3_branch.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100915/11e6c6f0/attachment-0002.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12887_v3_T3_4_4_branch.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100915/11e6c6f0/attachment-0001.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12887_v3_T3_trunk.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20100915/11e6c6f0/attachment-0003.txt>