[TYPO3-core] RFC #15644: Replace magic numbers for shortcut_mode with class constants

Steffen Kamper info at sk-typo3.de
Mon Sep 6 20:07:18 CEST 2010


Hi,

Ernesto Baschny [cron IT] schrieb:
> Please don't change the "==" with "===" in this patch, as this would
> mean a change of functionality and not only an introduction of
> constants. That should be a separate RFC, if someone wants to try that.
> 
> e.g.
> 
> 	if ($row['shortcut_mode'] == 0)
> 
> should be the same as
> 
> 	if ( (int)$row['shortcut_mode'] === 0 )
> 


i disagree :) shortcut_mode is int in DB, so no need for conversion.

vg Steffen


More information about the TYPO3-team-core mailing list