[TYPO3-core] FYI24 #16155: t3lib_db::INSERTquery misses a space when generering the INSERT INTO statement
Ernesto Baschny [cron IT]
ernst at cron-it.de
Fri Oct 29 10:06:27 CEST 2010
Ernesto Baschny [cron IT] schrieb am 28.10.2010 15:14:
> This is a SVN patch, which will be commited in 24h if nobody opposes.
>
> Type: Minor
>
> BT reference: http://bugs.typo3.org/view.php?id=16155
>
> Branches: trunk, TYPO3_4-4, TYPO3_4-3
>
> Problem:
> Since RFC #11813 (rev. 6203, 4.3.0 and later), a CGL cleanup on
> t3lib_db, the INSERTquery method generates a slightly non-conformant query:
>
> INSERT INTO table(field1, field2) VALUES ($value1, $value2);
>
> note the missing space after the tablename. Correct would be:
>
> INSERT INTO table (field1, field2) VALUES ($value1, $value2);
>
> While newer MySQL versions accept this silently, it might fail on pretty
> old MySQL servers.
>
> And it is not that beautiful. :)
>
> Solution:
> Add the missing space.
Committed to:
- trunk rev. 9218 (for 4.5beta1)
- TYPO3_4-4 rev. 9219 (for 4.4.5)
- TYPO3_4-3 rev. 9220 (for 4.3.9)
Cheers,
Ernesto
More information about the TYPO3-team-core
mailing list