[TYPO3-core] RFC #16140: Bug: PHP Warning on missing array in reports system extension

[Susanne Moog]

On 28.10.2010 08:23, Sebastian Fischer wrote:
> Am 27.10.2010 13:37, schrieb Rudi Meyer:
>> This is an SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references: http://bugs.typo3.org/view.php?id=16140
>>
>> Branches: TYPO3_4-4&  trunk
>>
>> Problem: PHP Warning on array_merge() in
>> /typo3/sysext/reports/ext_tables.php when
>> $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['reports']['tx_reports']['status']
>>
>> array not set.
>>
>> Solution: Only merge with conf array if array is present.
>>
>> -- 
>> Best regards
>> Rudi Meyer
>> Forlaget Systime
> 
> +1 by reading with one remark.
> 
> The line is definitly longer than 80 characters. Please insert
> linebreaks after the ? and the :. Its still exceeds the CGL numbers but
> its fare more readable.

Just fyi CGL changed a bit:
"Very long lines of code should be avoided for questions of readability.
A line length of about 130 characters (including tabs) is fine. Longer
lines should be split into several lines whenever possible."

So it's at least not 80 chars anymore ;)

Susanne