[TYPO3-core] RFC: #15094: Refactor of content objects of tslib_content

[Ernesto Baschny [cron IT]]

Hi Steffen,

you are still commiting MS-DOS line feeds in the new files you create.
Please check your PhpStorm again (and again). :)

I commited the following follow-ups:

1) rev. 9213 fixed indention in tslib/class.tslib_content.php (see
attached patch)
2) rev. 9214 fixed line endings in tslib/content/*

First fix probably came from a patch you created "ignoring
white-spaces". You should not apply those patches later on to commit, as
you will end up with these ugly indention problems.

Cheers,
Ernesto

Steffen Kamper schrieb am 27.10.2010 19:12:
> Hi,
> 
> Susanne Moog schrieb:
> 
>>
>> In general +1 by reading and testing with these notes (all of which can
>> be fixed upon commit imho):
>>
> thx!
> 
>> * tslib_content_abstract => shouldn't that be tslib_content_Abstract?
> changed
>> * protected $contentObjects = array (); (one space too much ;))
> fixed
>> * all new files have a trailing new line, please remove
>>
> removed
> 
> Committed to trunk rev 9209
> 
>> Further bla:
>> * Are you planning to externalize functions like "getImgResource", too
>> (as it would belong more to the imageresource class I guess)?
> 
> the problem is the backward compatibility, as you can call
> $this->cObj->getImgresource
> 
>> * Next workshop: Splitting typoLink ;)
> you are welcome ;)
> 
>> * I just used CTABLE, OTABLE and HRULER for the first time... Amazing *g*
>>
> 
> yeah, build a dinosaur website :)
> 
> vg Steffen

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 15094-indentionfix.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101027/3cb45cb6/attachment-0001.asc>