[TYPO3-core] RFC: #16130: Bug: buggy initialization of flash uploader when only certain file extensions are allowed

[Andreas Kiessling]

Hi,

this is a SVN patch request.

Type: Bugfix, almost nobrainer

BT reference: http://bugs.typo3.org/view.php?id=16130

Branches: 4_3, 4_4, trunk

With $TYPO3_CONF_VARS['BE']['fileExtensions']['webspace']['allow'] = 
'png,gif,jpg,jpeg,pdf' you can configure certain allowed filetypes. The 
flashuploader takes this setting into account and limits what you can 
actually select, but during its initialization, some errors happen.

When you set this option in your extTables.php and open the uploader, 
you just get a message with a hint for the maximum possible filesize for 
the upload. Close the uploader and open it again: now you see a message, 
which filetypes are allowed.

When you have set it to the mentioned filetypes, you will now see only 
'png,gif,jpg,jpeg', because the used function TYPO3.helpers.split to 
create the required format for the settings for the uploader is buggy 
and imho not needed at all, since JS already has a split function.

Solution: init the settings for the restrictions when the flash uploader 
is called and use the built in split function.

That helper method from common.js should be removed / deprecated and i 
only found it to be used from the flash uploader. The error is present 
since the uploader was first introduced in 4.3, but for 4.3 the trunk 
patch does not apply.

Regards,
Andreas
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16130_v1_4-3.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101026/4c6dcaf5/attachment.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16130_v1_trunk.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101026/4c6dcaf5/attachment.txt>