[TYPO3-core] RFC #15621: Feature: TYPO3 misses page-option to force SSL oder Non-SSL to page

Jeff Segars jsegars at alumni.rice.edu
Tue Oct 12 21:57:49 CEST 2010


On 10/12/10 12:29 PM, Steffen Kamper wrote:
> Hi,
>
>
> Steffen Kamper schrieb:
>> Hi,
>>
>> +1 by reading and testing with 3 comments
>>
>> 1) shouldn't "URL-Scheme" read "URL Scheme" ?
>> 2) (int)$this->page['url_scheme'] - the DV field is int, so why type
>> casting?
>> 3) $page['url_scheme']·==·t3lib_utility_http::SCHEME_HTTP - all others
>> are strict, so please here too
>> And removal of 2 spaces can be done while commit.
>>
>
> and here is the patch taking this into account.
>
> i also changed comparison with http:// and https:// to be sure.
>
> vg Steffen
>

Attached v6 uses parse_url to determine the scheme in both tslib_content 
and tslib_fe so we don't have to mess with the :// junk anymore :) Also, 
a few CGL cleanups....


-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 15621_v6.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101012/672d78ac/attachment.asc>


More information about the TYPO3-team-core mailing list