[TYPO3-core] RFC: #15942: locallangXMLOverride should not distinguish between paths ending with php and xml (like readLLfile)

Andreas Kiessling kiessling at pluspol.info
Mon Oct 11 20:54:27 CEST 2010


Hi,

This is a SVN patch request.

Type: Bugfix

BT reference: http://bugs.typo3.org/view.php?id=15942

Branches: 4_4, trunk

Problem: With locallangXMLOverride you are able to override any label. A 
lot of backend labels are still configured like this:

'title' => 'LLL:EXT:lang/locallang_tca.php:pages',

To override such a label, you have to use
$GLOBALS['TYPO3_CONF_VARS']['SYS']['locallangXMLOverride']['EXT:lang/locallang_tca.php'][] 
= 'PATH_TO_MY_XML';
whereas the label is stored in an locallang_tca.xml file.

readLLfile removes the file extension when it is called with a filepath, 
checks if there is a xml file and uses that one. If there is no xml, it 
checks for a php file.

When you use locallangXMLOverride however, you need to set the filepath 
not to the actual path of the xml file, but to the path with which 
readLLfile is called. This is inconsistent and so you have to include 
two override statements to make sure to catch all labels.

Solution: check if there are overrides set for php and xml paths

Note: patch is for current trunk, but applies to 4.4 with some offset
Note2: it is labeled v2 because i renamed a temp var since posting it to 
the bt


Regards,
Andreas
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 15942_v2.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101011/e3b1ad59/attachment.asc>


More information about the TYPO3-team-core mailing list