[TYPO3-core] RFC #15800: Cleanup CSH Code

[Steffen Kamper]

Hi,

in general +1, but i have some remarks :)

3rd chunk (+if (typeof Prototype != 'undefined') {) has nothing to do 
with RFC

TYPO3.Help:
please use something else like
TYPO3.ContextHelpWindow
and move it to t3lib/js/extjs/notifications.js, i think this match much 
better

popupUrl: 'view_help.php?tfID='
i would use complete url:
popupUrl: top.TYPO3.configuration.PATH_typo3 + 'view_help.php?tfID='

then backpath isn't needed.

in general i would move it completely to the top object, use a singleton 
class and just call it.
Also the CGL (varnames, linebraks etc) should be adjusted.
Ext.DomQuery.select <= DomQuery is not needed, Ext.select is ok.

Now as i had so much comments i will come with an updated patch asap :)

vg Steffen