[TYPO3-core] RFC #12887: Bug: User Tools/Worspace screen stage change buttons problem

[Christopher Hlubek]

Hi,

+1 by testing and reading.

I've tested the patch for 4.4 and it fixes the problem. I think this 
issue is not trivial as the workspace module is currently broken for our 
users! Just check the different behaviour between the version and 
workspace module, it's easy to reproduce.

I think the check for $rec_off['t3ver_stage'] < 10 is okay in the outer 
if statement.

This should be applied to the core as soon as possible.

Greetings,

Christopher

Gosign | Caspar Stuebs schrieb:
>>
>> This should be fixed too ;)
> 
> First, I don't think that this is a problem due to the fact the the
> given line is not called if $rec_off['t3ver_stage'] == 10.
> 
> In my opinion the check if ($rec_off['t3ver_stage'] != 10) (or < 10 !?)
> should by moved to the parent if statement, because the $onClick
> variable is not used at all if $rec_off['t3ver_stage'] == 10.
> 
> The second thing is, that the reject action should not be parsed, if the
> state is 'editing' ($rec_off['t3ver_stage'] == 0), because I don't see
> the need that an editor should reject his own work before sending it to
> review. So for the reject if statement it should be
> ($rec_off['t3ver_stage'] > 0)
> 
> I have added 3 patches _v3 for 4.3, 4.4 and Trunk, including these changes.