[TYPO3-core] RFC #16591 The new Swift Mailer should be used by TYPO3 for sending all kinds of mail

[Jeff Segars]

On 11/30/10 12:35 AM, Jigal van Hemert wrote:
> Hi,
>
> Attached v3 which takes into account the changed class name in the
> follow-up to #15998.
>

Hey Jigal,

+1 on reading and testing, with a few comments for discussion :)

* Is the tx_ prefix needed on the new class so that the hook works as 
expected? It seems a little out of place otherwise :)

* In the setHeader() method, would it make sense to refactor the parts 
that process mailbox headers into a common method? Even if it stays as 
is, a few comments about what it is doing at that point might be helpful :)

* Would it make sense to move unEscapeShellArg() to somewhere like 
t3lib_div since its generally useful and not specific to mail 
functionality? I would call it unescapeShellArg() also.

* And my last question is a big picture conceptual one.  It seems a 
little bit funny that t3lib_utilityMail::mail() calls a hook or  falls 
back to the built-in mail() function when the core will always be 
setting the hook. Would it make more sense to call the new sendMail() 
function directly in the else case of t3lib_utilityMail::mail()

Thanks!
Jeff