[TYPO3-core] RFC #16470: Bug: Scheduler fails to calculateNextValue a turn of the year

[Christian Kuhn]

On 11/27/2010 11:18 AM, Tobias Hövelborn wrote:
> Thanks for your hint, test is attached. It does the following:
> Check if the nextValue for a "every Monday" Command following on Tue
> 28.12.2010 is the 3.1.2011 (and not the 10th as currently calculated).

Great! Many thanks for digging into this method!
Attached version just changes some CGL things and adds another simple test.

I was unable to come up with a test which worked before and failes after 
your change. Thus: +1 on reading and testing.


Notes:
Man, this method is nifty. It deserves refactoring and splitting to 
multiple methods. I'd suggest to rewrite it from scratch and backup 
every single line with unit tests. That's probably the only way to get a 
bug free version.
I created http://bugs.typo3.org/view.php?id=16611 and added another 
currently failing test scenario for this method (there are probably more 
of them).

Regards
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16470_03.diff
Type: text/x-patch
Size: 1033 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101129/123a9c8d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16470-test_03.diff
Type: text/x-patch
Size: 1952 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101129/123a9c8d/attachment-0001.bin>