[TYPO3-core] RFC #16333: Bug: Make scheduler's execution class fully testable

[Christian Kuhn]

On 11/10/2010 05:48 PM, Marcus Krause wrote:
> Solution:
> Use global EXEC_TIME by default (set in constructor) and add
> getter/setter to modify the time (for unit test usage).

@@ -274,7 +312,7 @@
-»··»···return $this->start < time();
+»··»···return $this->start <= $this->currentTimestamp;

Did you changed < to <= for some reason? (Reverted in attached version).

Beside that I changed the setter to throw exceptions and adapted the 
tests accordingly.

+1 on reading and testing.

Thanks
Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16333_02.diff
Type: text/x-patch
Size: 3154 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101129/5f3c823f/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16333-test_02.diff
Type: text/x-patch
Size: 2801 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101129/5f3c823f/attachment-0003.bin>