[TYPO3-core] RFC #16574: Bug/Cleanup: PHP notices from XCLASS inclusions

[Susanne Moog]

On 26.11.2010 12:54, Susanne Moog wrote:
> Hey,
> 
> This is an SVN patch request.
> 
> Type: bug / cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=16574
> 
> Branches:
> trunk
> 
> Problem:
> The default XCLASS inclusion generates PHP notices as it uses
> $TYPO3_CONF_VARS and tries to access undefined array indexes.
> 
> Solution:
> Fix by using $GLOBALS['TYPO3_CONF_VARS'] and isset()
> 
> Notes / How to test:
> Apply the patch and see that everything including XClasses still works.
> I additionally checked for syntax errors by using "find ./ -name '*.php'
> | xargs -I% /usr/bin/php -l %"
> 

ok, here is v3 taking all comments into account (thanks Oli, for the
regex ;))

I already divided the patch like Steffen said.

Susanne

-- 
What's worth the price is always worth the fight
Every second counts 'cause there's no second try

TYPO3 Core Team Member
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16574_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101126/a7f1577b/attachment-0002.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16574_v3_dbal.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101126/a7f1577b/attachment-0002.asc>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16574_v3_pagetree.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101126/a7f1577b/attachment-0003.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 16574_v3_versioning.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101126/a7f1577b/attachment-0003.asc>