[TYPO3-core] RFC #16574: Bug/Cleanup: PHP notices from XCLASS inclusions

Susanne Moog typo3 at susannemoog.de
Fri Nov 26 14:04:28 CET 2010


On 26.11.2010 13:59, Oliver Klee wrote:
> Hi,
> 
> +1 by reading except for the following parts which look like they change
> more than they ought to:

arg automatic search and replace did strange things on the
xmenu_layers.diff file, these of course shouldn't be included.

>> Index: typo3/sysext/cms/tslib/class.tslib_content.php
>> ===================================================================
>> --- typo3/sysext/cms/tslib/class.tslib_content.php	(Revision 9643)
>> +++ typo3/sysext/cms/tslib/class.tslib_content.php	(Arbeitskopie)
>> @@ -564,6 +564,7 @@
>>  	 * @return	void
>>  	 */
>>  	function start($data, $table = '') {
>> +		error_reporting(E_ALL);
>>  		global $TYPO3_CONF_VARS;
>>  		$this->data = $data;
>>  		$this->table = $table;

This is fixed in v2.


> Here, there is a typo: iset -> isset:

that's no typo ;) that's the regular expression I came up with for a
possible but not necessary "isset(" in front of the XClass inclusion.

Thanks for reading :-)

Susanne


-- 
What's worth the price is always worth the fight
Every second counts 'cause there's no second try

TYPO3 Core Team Member


More information about the TYPO3-team-core mailing list