[TYPO3-core] FYI: #14050: CleanUp - CGL format of t3lib files - t3lib_svbase

[Jigal van Hemert]

Hi,

On 24-11-2010 16:45, Steffen Kamper wrote:
> PS - this class needs additional cleaning and fixes. There are many
> comments like "Do not work and commented out code

Attached a patch with additional cleaning and fixes:
- correct phpdoc var types
- phpdoc @param corrected
- fixed incorrect param order in a call
- removed early returns
- removed unused variables inside functions
- removed some useless comments

What's left is the partly useless init() and __destruct(); I left them 
in this class as inspiration for authors of services, because the code 
in this abstract class will not be called unless the child class calls it.

Does this need a separate RFC?

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: svbase_cleanup.patch
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101124/bb79dbaa/attachment-0001.asc>