[TYPO3-core] RFC #16559: Tweak: Ugly errors in install tool

Wed Nov 24 19:53:18 CET 2010

I am so sorry,
i think something went wrong with my mail client,
i will upload the diff file an other way

Regards,
Kevin

On 2010-11-24 19:52:01 +0100, Kevin Walter said:

> This is a multi-part message in MIME format.
> 
> 
> 
> ----------------10593896861213257483
> 
> Content-Type: text/plain; charset=iso-8859-1; format=flowed
> 
> Content-Transfer-Encoding: 8bit
> 
> 
> 
> This is an SVN patch request.
> 
> 
> 
> Type: Bugfix
> 
> 
> 
> Bugtracker references:
> 
> http://bugs.typo3.org/view.php?id=16559
> 
> 
> 
> Branches:
> 
> trunk
> 
> 
> 
> Problem:
> 
> There are some really ugly errors in the install tool, that just give a die.
> 
> its about the following errors: 
> 
> 
> 
> if the localconf does not contain a install tool password, it results in a die
> 
> if the typo3temp/ folder is not writeable it results in a die
> 
> 
> 
> i have fixed that with the code as attachment
> 
> 
> 
> Solution:
> 
> In stead of calling a die, i called the function: outputErrorAndExit
> 
> 
> 
> Yours Sincerely
> 
> Kevin Walter
> 
> ----------------10593896861213257483
> 
> Content-Type: multipart/related; 
> boundary=--------------1220393106861870848; type="text/html"
> 
> 
> 
> ----------------1220393106861870848
> 
> Content-Type: text/html; charset=iso-8859-1
> 
> Content-Transfer-Encoding: 8bit
> 
> 
> 
> <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" 
> "http://www.w3.org/TR/html4/strict.dtd">
> 
> <html>
> 
> <head>
> 
> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
> 
> <meta http-equiv="Content-Style-Type" content="text/css">
> 
> <title></title>
> 
> <meta name="Generator" content="Cocoa HTML Writer">
> 
> <meta name="CocoaVersion" content="1038.35">
> 
> <style type="text/css">
> 
> p.p1 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica}
> 
> p.p2 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; 
> min-height: 14.0px}
> 
> p.p3 {margin: 0.0px 0.0px 0.0px 0.0px; font: 12.0px Helvetica; color: #174fae}
> 
> p.p4 {margin: 0.0px 0.0px 0.0px 0.0px}
> 
> span.s1 {text-decoration: underline}
> 
> span.s2 {font: 12.0px Helvetica}
> 
> </style>
> 
> </head>
> 
> <body>
> 
> <p class="p1">This is an SVN patch request.</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">Type: Bugfix</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">Bugtracker references:</p>
> 
> <p class="p3"><span class="s1"><a 
> href="http://bugs.typo3.org/view.php?id=16559">http://bugs.typo3.org/view.php?id=16559</a></span></p>
<p 
> 
> class="p2"><br></p>
> 
> <p class="p1">Branches:</p>
> 
> <p class="p1">trunk</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">Problem:</p>
> 
> <p class="p1">There are some really ugly errors in the install tool, 
> that just give a die.</p>
> 
> <p class="p1">its about the following errors:<span 
> class="Apple-converted-space"> </span></p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">if the localconf does not contain a install tool 
> password, it results in a die</p>
> 
> <p class="p1">if the typo3temp/ folder is not writeable it results in a die</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">i have fixed that with the code as attachment</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">Solution:</p>
> 
> <p class="p1">In stead of calling a die, i called the function: 
> outputErrorAndExit</p>
> 
> <p class="p2"><br></p>
> 
> <p class="p1">Yours Sincerely</p>
> 
> <p class="p1">Kevin Walter</p>
> 
> <p class="p4"><span class="s2"><object 
> data="cid:D2E14BB5-6509-4113-A5B6-17F55FED9505">16559.diff</object></span></p>
</body>
</html>
----------------1220393106861870848
Content-Disposition: 
> 
> inline; filename=16559.diff
> 
> Content-Transfer-Encoding: base64
> 
> Content-Type: application/octet-stream; name="16559.diff"
> 
> Content-Id: <D2E14BB5-6509-4113-A5B6-17F55FED9505>
> 
> 
> 
> SW5kZXg6IHR5cG8zL3N5c2V4dC9pbnN0YWxsL21vZC9jbGFzcy50eF9pbnN0YWxsLnBocAo9
> 
> PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
> 
> PT09PT09PT09PT09Ci0tLSB0eXBvMy9zeXNleHQvaW5zdGFsbC9tb2QvY2xhc3MudHhfaW5z
> 
> dGFsbC5waHAJKHJldmlzaW9uIDk1NjApCisrKyB0eXBvMy9zeXNleHQvaW5zdGFsbC9tb2Qv
> 
> Y2xhc3MudHhfaW5zdGFsbC5waHAJKHdvcmtpbmcgY29weSkKQEAgLTI2OSw3ICsyNjksOSBA
> 
> QAogCWZ1bmN0aW9uIHR4X2luc3RhbGwoKSB7CiAJCXBhcmVudDo6dDNsaWJfaW5zdGFsbCgp
> 
> OwogCi0JCWlmICghJEdMT0JBTFNbJ1RZUE8zX0NPTkZfVkFSUyddWydCRSddWydpbnN0YWxs
> 
> VG9vbFBhc3N3b3JkJ10pCWRpZSgiSW5zdGFsbCBUb29sIGRlYWN0aXZhdGVkLjxiciAvPllv
> 
> dSBtdXN0IGVuYWJsZSBpdCBieSBzZXR0aW5nIGEgcGFzc3dvcmQgaW4gdHlwbzNjb25mL2xv
> 
> Y2FsY29uZi5waHAuIElmIHlvdSBpbnNlcnQgdGhlIGxpbmUgYmVsb3csIHRoZSBwYXNzd29y
> 
> ZCB3aWxsIGJlICdqb2gzMTYnOjxiciAvPjxiciAvPlwkVFlQTzNfQ09ORl9WQVJTWydCRSdd
> 
> WydpbnN0YWxsVG9vbFBhc3N3b3JkJ10gPSAnYmFjYjk4YWNmOTdlMGI2MTEyYjFkMWI2NTBi
> 
> ODQ5NzEnOyIpOworCQlpZiAoISRHTE9CQUxTWydUWVBPM19DT05GX1ZBUlMnXVsnQkUnXVsn
> 
> aW5zdGFsbFRvb2xQYXNzd29yZCddKSB7CisJCQkkdGhpcy0+b3V0cHV0RXJyb3JBbmRFeGl0
> 
> KCJJbnN0YWxsIFRvb2wgZGVhY3RpdmF0ZWQuPGJyIC8+WW91IG11c3QgZW5hYmxlIGl0IGJ5
> 
> IHNldHRpbmcgYSBwYXNzd29yZCBpbiB0eXBvM2NvbmYvbG9jYWxjb25mLnBocC4gSWYgeW91
> 
> IGluc2VydCB0aGUgbGluZSBiZWxvdywgdGhlIHBhc3N3b3JkIHdpbGwgYmUgJ2pvaDMxNic6
> 
> PGJyIC8+PGJyIC8+XCRUWVBPM19DT05GX1ZBUlNbJ0JFJ11bJ2luc3RhbGxUb29sUGFzc3dv
> 
> cmQnXSA9ICdiYWNiOThhY2Y5N2UwYjYxMTJiMWQxYjY1MGI4NDk3MSc7IiwgJ0ZhdGFsIGVy
> 
> cm9yJyk7CisJCX0KIAogCQlpZiAoJHRoaXMtPnNlbmROb0NhY2hlSGVhZGVycykgewogCQkJ
> 
> aGVhZGVyKCdFeHBpcmVzOiBNb24sIDI2IEp1bCAxOTk3IDA1OjAwOjAwIEdNVCcpOwpAQCAt
> 
> MzU0LDcgKzM1Niw3IEBACiAJCQkoJHRoaXMtPnN0ZXA/ICcmc3RlcD0nIC4gJHRoaXMtPnN0
> 
> ZXAgOiAnJyk7CiAJCSR0aGlzLT50eXBvM3RlbXBfcGF0aCA9IFBBVEhfc2l0ZS4ndHlwbzN0
> 
> ZW1wLyc7CiAJCWlmICghaXNfZGlyKCR0aGlzLT50eXBvM3RlbXBfcGF0aCkgfHwgIWlzX3dy
> 
> aXRlYWJsZSgkdGhpcy0+dHlwbzN0ZW1wX3BhdGgpKSB7Ci0JCQlkaWUoJ0luc3RhbGwgVG9v
> 
> bCBuZWVkcyB0byB3cml0ZSB0byB0eXBvM3RlbXAvLiBNYWtlIHN1cmUgdGhpcyBkaXJlY3Rv
> 
> cnkgaXMgd3JpdGVhYmxlIGJ5IHlvdXIgd2Vic2VydmVyOiAnLiAkdGhpcy0+dHlwbzN0ZW1w
> 
> X3BhdGgpOworCQkJJHRoaXMtPm91dHB1dEVycm9yQW5kRXhpdCgnSW5zdGFsbCBUb29sIG5l
> 
> ZWRzIHRvIHdyaXRlIHRvIHR5cG8zdGVtcC8uIE1ha2Ugc3VyZSB0aGlzIGRpcmVjdG9yeSBp
> 
> cyB3cml0ZWFibGUgYnkgeW91ciB3ZWJzZXJ2ZXI6ICcuICR0aGlzLT50eXBvM3RlbXBfcGF0
> 
> aCwgJ0ZhdGFsIGVycm9yJywgJ2Vycm9yJyk7CiAJCX0KIAogCQl0cnkgewo=
> 
> 
> 
> ----------------1220393106861870848--
> 
> 
> 
> ----------------10593896861213257483--
> 
> 
>