[TYPO3-core] RFC #16376: Feature: New TYPO3_DB method for select queries that fetch data from up to 3 tables based on RDF like triples

Jigal van Hemert jigal at xs4all.nl
Tue Nov 16 20:43:39 CET 2010


Hi,

On 15-11-2010 18:26, JoH asenau wrote:
>> v2 of the mmm_query fixes CGL issues and a bug with missing table
>> names, if there were aliases available.
>
> Attached is v3 because version 2 had an optional first parameter, which should not be the case in PHP.

One minor thing which can be done at commit I guess is to initialize 
$mmmWhere somewhere in the start of the function. It's used for the 
first time inside the if($firstTable) block with a .= operator.

+1 by reading (and dry testing the generated parameters for the 
exec_SELECTquery() call)

-- 
Kind regards / met vriendelijke groet,

Jigal van Hemert
skype:jigal.van.hemert
msn: jigal at xs4all.nl
http://twitter.com/jigalvh


More information about the TYPO3-team-core mailing list