[TYPO3-core] RFC #16375: Add a new TypoScript option "resolution" to the image resource

Dmitry Dulepov dmitry at typo3.org
Tue Nov 16 14:42:56 CET 2010


Hi!

Stefan Geith wrote:
>> -1 because this code can multiply numbers by NULL, which is... let's
>> say, it is just bad coding.
>
> No, it can't, because: "( $resolutionFactor && "

It does not matter! Have you heard about defensive programming? What if 
that value (with NULL) is used by somebody else later in the function?

> But I'll change this to 0 if needed...

It must be changed. There is no question... Please, do! :)

-- 
Dmitry Dulepov
TYPO3 core&security team member
Twitter: http://twitter.com/dmitryd
Read more @ http://dmitry-dulepov.com/


More information about the TYPO3-team-core mailing list