[TYPO3-core] RFC #16375: Add a new TypoScript option "resolution" to the image resource

[Steffen Gebert]

>> -1 because this code can multiply numbers by NULL, which is... let's
>> say, it is just bad coding.
>
> No, it can't, because: "( $resolutionFactor && "
> But I'll change this to 0 if needed...

Okay, you're right. However when dealing with numbers I would also go 
for 0 (and maybe compare $resulutionFactor > 0 to make it more readable).

Some nitch-picking:
* $originalImageIsSmaller instead of $origImageIsSmaller
* What t
* I prefer the $originalImageIsSmaller condition split up for better 
readability
* "// params could realisticly change some imagedata!" what does this 
mean? I know it's not from you, but realisticly is no word. Can we 
improve that comment? Replacing it with "realistic" gives me not so much 
more understanding, without reading all the code. "$params could have 
changed image data"?

Please check attached patch!

Kind regards
Steffen

-- 
Steffen Gebert
TYPO3 Core Team Member

Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 16375_v2.diff
Type: text/x-diff
Size: 5517 bytes
Desc: not available
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20101116/6f87ff98/attachment.diff>