[TYPO3-core] RFC #16376: Feature: New TYPO3_DB method for select queries that fetch data from up to 3 tables based on RDF like triples
JoH asenau
info at cybercraft.de
Sat Nov 13 19:37:21 CET 2010
> Can you have a look at your newsgroup client please? It is attaching
> your patches as binary instead of text/plain.
I am currently moving to Thunderbird, but not yet there.
So I just can't attach stuff another way. Sorry!
> Thanks.
>
> Concerning your patch. I did not test it but:
>
> - visibility is missing
> - CGL is not respected around concatenation, e.g., first 2 statements
> of the new method
> - fullQuoteStr() should be used instead of manually single quoting
> where clause
Will do.
> What is this comment?
>
> // whereClauseMightContainGroupOrderByButShouldNotContainThose
Was left in from the original patch by Lieuwe Hummel.
Can be removed.
Thx for the review
v2 follows
Joey
--
Wenn man keine Ahnung hat: Einfach mal Fresse halten!
(If you have no clues: simply shut your gob sometimes!)
Dieter Nuhr, German comedian
Xing: http://contact.cybercraft.de
Twitter: http://twitter.com/bunnyfield
TYPO3 cookbook (2nd edition): http://www.typo3experts.com
More information about the TYPO3-team-core
mailing list