[TYPO3-core] RFC #16333: Bug: Make scheduler's execution class fully testable

[Oliver Klee]

Hi,

+1 by reading with the followings nits:

- Please add two tests:
  a) that the constructor copies the timestamp from $GLOBALS['EXEC_TIME'];
  b) that the setter sets the time

> -					$now = time();
> -					$date = $now + $this->interval - (($now - $this->start) % $this->interval);
> +					$date = $this->currentTimestamp + $this->interval - (($this->currentTimestamp - $this->start) % $this->interval);

I think this will be more readable if you keep using $now (your decision
...):

$now = $this->currentTimestamp;

- I haven't read the scheduler code yet. Have you checked that the
scheduler doesn't rely on the timestamps being different before and
running after a job?


Oli
-- 
Certified TYPO3 Integrator | TYPO3 Security Team Member