[TYPO3-core] RFC #7942: Enable UTF-8 by default
Steffen Gebert
steffen at steffen-gebert.de
Wed Nov 10 12:21:34 CET 2010
Hi Benni and Stucki,
you made me really happy with this RFC :) Thanks!
Just after some short reading:
> $dbConnectionIsUtf8 = trim($GLOBALS['TYPO3_CONF_VARS']['SYS']['setDBinit'], ' ;') == 'SET NAMES utf8' ? TRUE : FALSE;
? TRUE : FALSE is not needed, as == returns boolean.
I also have "SET CHARACTER SET utf8" from some older advices of "how to
do utf-8" in mind (e.g. see [1]). This case would not be covered by this
line, however reading the character_set_* variables would lead to the
correct decision, wouldn't it?
Kind regards
Steffen
--
[1] http://bugs.typo3.org/bug_view_advanced_page.php?bug_id=14882
Steffen Gebert
TYPO3 Core Team Member
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/
More information about the TYPO3-team-core
mailing list